@@ -1,4 +1,9 @@

 -------------------------------------------------------------------

+Sat Aug 24 19:53:47 UTC 2024 - Bjørn Lie <zaitor@opensuse.org>

+

+- Update to version 1.24.7

+

+-------------------------------------------------------------------

 Mon Aug  5 17:33:08 UTC 2024 - Bjørn Lie <zaitor@opensuse.org>

 - Update to version 1.24.6

​

@@ -7,7 +7,7 @@

 %define _version 1.24.0

 Name:           gstreamer-plugins-bad-codecs

-Version:        1.24.6

+Version:        1.24.7

 Release:        0

 Summary:        Codecs/plugins for gstreamer-plugins-bad

 License:        LGPL-2.1-or-later

​

@@ -1,3 +1,101 @@

+=== release 1.24.7 ===

+

+2024-08-21 12:25:15 +0100  Tim-Philipp Müller <tim@centricular.com>

+

+   * NEWS:

+   * RELEASE:

+   * gst-plugins-bad.doap:

+   * meson.build:

+     Release 1.24.7

+

+2024-08-19 12:39:21 +0200  Guillaume Desmottes <guillaume.desmottes@onestream.live>

+

+   * ext/wpe/gstwpethreadedview.cpp:

+     wpe: initialize threading.ready before reading it

+     Fixes Valgrind warning.

+     Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7385>

+

+2024-08-19 14:34:28 +0200  Víctor Manuel Jáquez Leal <vjaquez@igalia.com>

+

+   * sys/va/gstvabasedec.c:

+   * sys/va/gstvabaseenc.c:

+   * sys/va/gstvabasetransform.c:

+   * sys/va/gstvacompositor.c:

+     va: don't use GST_ELEMENT_WARNING in set_context() vmethod

+     Since bins can set the context of their children elements, the set_context()

+     vmethod shouldn't call bus messages post methods, since it locks the parent

+     object, the bin, which might be already locked, leading to a deadlock.

+     Fixes: #3706

+     Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7379>

+

+2024-07-22 21:29:38 +0800  Qian Hu (胡骞) <qian.hu@mediatek.com>

+

+   * gst-libs/gst/codecparsers/gsth264parser.c:

+   * gst-libs/gst/codecparsers/gsth265parser.c:

+   * tests/check/libs/h264parser.c:

+     h26xparse: bypass check for length_size_minus_one

+     fix playback fail, when some file with length_size_minus_one == 2

+     According to the spec 2 cannot be a valid value, so that stream has a

+     bad config record. but breaking the decoding because of that, perhaps is too much.

+     and ffmpeg seem not check this

+     Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7358>

+

+2024-08-13 10:42:31 +0200  Víctor Manuel Jáquez Leal <vjaquez@igalia.com>

+

+   * sys/msdk/gstmsdkav1enc.c:

+   * sys/msdk/gstmsdkcontext.c:

+   * sys/msdk/gstmsdkh264enc.c:

+   * sys/msdk/gstmsdkh265enc.c:

+   * sys/msdk/gstmsdkmpeg2enc.c:

+   * sys/msdk/gstmsdkvc1dec.c:

+   * sys/msdk/gstmsdkvp9enc.c:

+     msdk: replace strcmp with g_strcmp0

+     Because strcmp doesn't handle NULL.

+     Fixes: #3721

+     Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7349>

+

+2024-08-07 19:14:26 +0100  Tim-Philipp Müller <tim@centricular.com>

+

+   * docs/plugins/gst_plugins_cache.json:

+   * ext/aom/gstav1enc.c:

+     aom: av1enc: restrict allowed input width and height

+     Restrict allowed input resolution to something sensible

+     in light of libaom CVE-2024-5171.

+     Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7328>

+

+2024-08-06 22:48:16 +1000  Jan Schmidt <jan@centricular.com>

+

+   * gst-libs/gst/webrtc/webrtc_fwd.h:

+     webrtc: Add missing G_BEGIN/END_DECLS in header

+     Fix using webrtc.h from C++ by adding the GLib begin/end

+     decls markers around the header contents in webrtc_fwd.h

+     Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7313>

+

+2024-07-03 07:58:58 -0600  Jordan Yelloz <jordan.yelloz@collabora.com>

+

+   * gst/videoparsers/gsth265parse.c:

+     h265parse: Reject FD received before SPS

+     A previous fix, a275e1e029e9b5d88be26b8304c9a162e4567346, is correct but was too

+     permissive since it treats all un-matched NAL units the same as AU delimiters

+     even though some other NAL unit types can be encountered in the processing loop.

+     The problem this can cause is that some hardware decoders experience bad

+     performance when handling FD units that precede the SPS.

+     This change restores the original behavior for FDs so that they're ignored until

+     the SPS is received and it preserves the codec conformance test gains that the

+     fix has achieved.

+     Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7296>

+

+2024-07-26 17:13:10 +0200  Guillaume Desmottes <guillaume.desmottes@onestream.live>

+

+   * ext/rsvg/gstrsvgoverlay.c:

+     rsvgoverlay: add debug category

+     Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7281>

+

+2024-07-29 16:48:02 +0100  Tim-Philipp Müller <tim@centricular.com>

+

+   * meson.build:

+     Back to development after 1.24.6

+

 === release 1.24.6 ===

 2024-07-29 16:41:37 +0100  Tim-Philipp Müller <tim@centricular.com>

​

@@ -2,11 +2,11 @@

 GStreamer 1.24.0 was originally released on 4 March 2024.

-The latest bug-fix release in the stable 1.24 series is 1.24.6 and was released on 29 July 2024.

+The latest bug-fix release in the stable 1.24 series is 1.24.6 and was released on 21 August 2024.

 See https://gstreamer.freedesktop.org/releases/1.24/ for the latest version of this document.

-Last updated: Monday 29 July 2024, 14:30 UTC (log)

+Last updated: Tuesday 20 August 2024, 20:30 UTC (log)

 ## Introduction

@@ -2289,6 +2289,133 @@

 -   List of Merge Requests applied in 1.24.6

 -   List of Issues fixed in 1.24.6

+1.24.7

+

+The seventh 1.24 bug-fix release (1.24.7) was released on 21 August 2024.

+

+This release only contains bugfixes and it should be safe to update from 1.24.x.

+

+Highlighted bugfixes in 1.24.7

+

+-   Fix APE and Musepack audio file and GIF playback with FFmpeg 7.0

+-   playbin3: Fix potential deadlock with multiple playbin3s with glimagesink used in parallel

+-   qt6: various qmlgl6src and qmlgl6sink fixes and improvements

+-   rtspsrc: expose property to force usage of non-compliant setup URLs for RTSP servers where the automatic fallback doesn’t

+    work

+-   urisourcebin: gapless playback and program switching fixes

+-   v4l2: various fixes

+-   va: Fix potential deadlock with multiple va elements used in parallel

+-   meson: option to disable gst-full for static-library build configurations that do not need this

+-   cerbero: libvpx updated to 1.14.1; map 2022Server to Windows11; disable rust variant on Linux if binutils is too old

+-   Various bug fixes, memory leak fixes, and other stability and reliability improvements

+

+gstreamer

+

+-   bin: Don’t keep the object lock while setting a GstContext when handling NEED_CONTEXT

+-   core: Log pad name, not just the pointer

+

+gst-plugins-base

+

+-   pbutils: descriptions: use subsampling factor to get YUV subsampling

+-   rtspconnection: Handle invalid argument properly

+-   urisourcebin: Actually drop EOS on old-school pad switch

+-   urisourcebin: Don’t hold lock when emitting about-to-finish

+-   gst-launch deadlock with two playbin3s

+-   xvimagesink: Fix crash in pool on error

+

+gst-plugins-good

+

+-   qmlgl6src: Fix crash when use-default-fbo is not set

+-   qt6glwindow: Fallback to GL_RGB on CopyTexImage2D error, fixing usage with eglfs backend

+-   qt6glwindow: Only use GL_READ_FRAMEBUFFER when we do blits

+-   qt6: glwindow: Don’t leak previously rendered buffer

+-   rtspsrc: expose property for forcing usage of non-compliant URLs

+-   v4l2object: fix ARIB_STD_B67 colorimetry unmatch issue

+-   v4l2: Fix colorimetry mismatch for encoded format with RGB color-matrix

+

+gst-plugins-bad

+

+-   aom: av1enc: restrict allowed input width and height

+-   h264parse: bypass check for length_size_minus_one

+-   h265parse: Reject FD received before SPS

+-   msdk: replace strcmp with g_strcmp0

+-   msdkvc1dec crashes (segfault)

+-   rsvgoverlay: add debug category

+-   va: don’t use GST_ELEMENT_WARNING in set_context() vmethod to fix potential deadlock

+-   va: deadlock when playing two videos at once

+-   webrtc: Add missing G_BEGIN/END_DECLS in header for C++

+-   wpe: initialize threading.ready before reading it

+

+gst-plugins-ugly

+

+-   No changes

+

+GStreamer Rust plugins

+

+-   gtk4: Move the dmabuf cfg to the correct bracket level

+

+gst-libav

+

+-   avdemux: Fix deadlock with FFmpeg 7.x when serialized events are received from upstream while opening, such as e.g. APE

+    files with tags

+-   libav: return EOF when stream is out of data

+-   avdemux: Never return 0 from read function, which would lead to infinite loops

+

+gst-rtsp-server

+

+-   No changes

+

+gstreamer-vaapi

+

+-   vaapi: Fix sps_max_dec_pic_buffering_minus1 value in h265 decoder

+

+gstreamer-sharp

+

+-   No changes

+

+gst-omx

+

+-   No changes

+

+gst-python

+

+-   No changes

+

+gst-editing-services

+

+-   nlecomposition: Don’t leak QoS events

+

+gst-devtools, gst-validate + gst-integration-testsuites

+

+-   validate: Fix copying of action name

+

+gst-examples

+

+-   No changes

+

+Development build environment

+

+-   Add a meson option to disable gst-full for static-library build configurations that do not need this

+

+Cerbero build tool and packaging changes in 1.24.7

+

+-   Disable rust variant on Linux if binutils is too old

+-   Added 2022Server to the Windows platform distro map as Windows11

+-   libvpx: Update to 1.14.1

+

+Contributors to 1.24.7

+

+David Rosca, Edward Hervey, Guillaume Desmottes, Hou Qi, Jan Schmidt, Jesper Jensen, Jordan Petridis, Jordan Yelloz, L. E.

+Segovia, Lyra McMillan, Mathieu Duponchelle, Max Romanov, Nicolas Dufresne, Nirbheek Chauhan, Qian Hu (胡骞), Sebastian Dröge,

+Tim-Philipp Müller, Víctor Manuel Jáquez Leal,

+

+… and many others who have contributed bug reports, translations, sent suggestions or helped testing. Thank you all!

+

+List of merge requests and issues fixed in 1.24.7

+

+-   List of Merge Requests applied in 1.24.7

+-   List of Issues fixed in 1.24.7

+

 Schedule for 1.26

 Our next major feature release will be 1.26, and 1.25 will be the unstable development version leading up to the stable 1.26

​

@@ -1,4 +1,4 @@

-This is GStreamer gst-plugins-bad 1.24.6.

+This is GStreamer gst-plugins-bad 1.24.7.

 The GStreamer team is thrilled to announce a new major feature release

 of your favourite cross-platform multimedia framework!

​

@@ -3613,7 +3613,7 @@

                 "long-name": "AV1 Encoder",

                 "pad-templates": {

                     "sink": {

-                        "caps": "video/x-raw:\n         format: { I420, Y42B, Y444, YV12 }\n      framerate:  0/1, 2147483647/1 \n          width:  4, 2147483647 \n         height:  4, 2147483647 \n",

+                        "caps": "video/x-raw:\n         format: { I420, Y42B, Y444, YV12 }\n      framerate:  0/1, 2147483647/1 \n          width:  4, 65536 \n         height:  4, 65536 \n",

                         "direction": "sink",

                         "presence": "always"

                     },

​

@@ -276,8 +276,8 @@

         GST_STATIC_CAPS ("video/x-raw, "

         "format = (string) { I420, Y42B, Y444, YV12 }, "

         "framerate = (fraction) 0, MAX, "

-        "width = (int)  4, MAX , "

-        "height = (int)  4, MAX ")

+        "width = (int)  4, 65536 , "

+        "height = (int)  4, 65536 ")

     );

 /* *INDENT-ON* */

​

@@ -85,6 +85,9 @@

   PROP_HEIGHT_RELATIVE

 };

+GST_DEBUG_CATEGORY_STATIC (rsvg_overlay_debug);

+#define GST_CAT_DEFAULT rsvg_overlay_debug

+

 #define GST_RSVG_LOCK(overlay) G_STMT_START { \

   GST_LOG_OBJECT (overlay, "Locking rsvgoverlay from thread %p", g_thread_self ()); \

   g_mutex_lock (&overlay->rsvg_lock); \

@@ -122,7 +125,12 @@

     GST_STATIC_CAPS ("image/svg+xml; image/svg; text/plain"));

 #define gst_rsv_overlay_parent_class parent_class

-G_DEFINE_TYPE (GstRsvgOverlay, gst_rsvg_overlay, GST_TYPE_VIDEO_FILTER);

+

+#define _do_init \

+    GST_DEBUG_CATEGORY_INIT (rsvg_overlay_debug, "rsvgoverlay", 0, "SVG Overlay");

+

+G_DEFINE_TYPE_WITH_CODE (GstRsvgOverlay, gst_rsvg_overlay,

+    GST_TYPE_VIDEO_FILTER, _do_init);

 GST_ELEMENT_REGISTER_DEFINE (rsvgoverlay, "rsvgoverlay", GST_RANK_NONE,

     GST_TYPE_RSVG_OVERLAY);

​

@@ -73,6 +73,7 @@

 {

     g_mutex_init(&threading.mutex);

     g_cond_init(&threading.cond);

+    threading.ready = FALSE;

     {

         GMutexHolder lock(threading.mutex);

​

@@ -3781,8 +3781,6 @@

   if (ret->length_size_minus_one == 2) {

     /* "length_size_minus_one + 1" should be 1, 2, or 4 */

     GST_WARNING ("Wrong nal-length-size");

-    result = GST_H264_PARSER_ERROR;

-    goto error;

   }

   /* reserved 3bits */

​

@@ -5093,8 +5093,6 @@

   if (ret->length_size_minus_one == 2) {

     /* "length_size_minus_one + 1" should be 1, 2, or 4 */

     GST_WARNING ("Wrong nal-length-size");

-    result = GST_H265_PARSER_ERROR;

-    goto error;

   }

   READ_CONFIG_UINT8 (num_of_arrays, 8);

​

@@ -32,6 +32,8 @@

  * @title: GstWebRTC Enumerations

  */

+G_BEGIN_DECLS

+

 #ifndef GST_WEBRTC_API

 # ifdef BUILDING_GST_WEBRTC

 #  define GST_WEBRTC_API GST_API_EXPORT         /* from config.h */

@@ -516,4 +518,6 @@

   GST_WEBRTC_ERROR_TYPE_ERROR,

 } GstWebRTCError;

+G_END_DECLS

+

 #endif /* __GST_WEBRTC_FWD_H__ */

​

@@ -35,6 +35,16 @@

  <release>

   <Version>

+   <revision>1.24.7</revision>

+   <branch>1.24</branch>

+   <name></name>

+   <created>2024-08-21</created>

+   <file-release rdf:resource="https://gstreamer.freedesktop.org/src/gst-plugins-bad/gst-plugins-bad-1.24.7.tar.xz" />

+  </Version>

+ </release>

+

+ <release>

+  <Version>

    <revision>1.24.6</revision>

    <branch>1.24</branch>

    <name></name>

​

@@ -981,6 +981,15 @@

       }

       break;

     }

+    case GST_H265_NAL_FD:

+      if (!GST_H265_PARSE_STATE_VALID (h265parse, GST_H265_PARSE_STATE_GOT_SPS)) {

+        GST_DEBUG_OBJECT (h265parse, "dropping FD received before SPS");

+        return FALSE;

+      }

+      pres = gst_h265_parser_parse_nal (nalparser, nalu);

+      if (pres != GST_H265_PARSER_OK)

+        return FALSE;

+      break;

     case GST_H265_NAL_AUD:

     default:

       /* Just accumulate AU Delimiter, whether it's before SPS or not */

​

@@ -1,5 +1,5 @@

 project('gst-plugins-bad', 'c', 'cpp',

-  version : '1.24.6',

+  version : '1.24.7',

   meson_version : '>= 1.1',

   default_options :  'warning_level=1',

                       'buildtype=debugoptimized' )

​

@@ -6,9 +6,9 @@

 #, fuzzy

 msgid ""

 msgstr ""

-"Project-Id-Version: gst-plugins-bad-1.24.6\n"

+"Project-Id-Version: gst-plugins-bad-1.24.7\n"

 "Report-Msgid-Bugs-To: \n"

-"POT-Creation-Date: 2024-07-29 16:42+0100\n"

+"POT-Creation-Date: 2024-08-21 12:27+0100\n"

 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"

 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"

 "Language-Team: LANGUAGE <LL@li.org>\n"

​

@@ -6,9 +6,9 @@

 #, fuzzy

 msgid ""

 msgstr ""

-"Project-Id-Version: gst-plugins-bad-1.24.6\n"

+"Project-Id-Version: gst-plugins-bad-1.24.7\n"

 "Report-Msgid-Bugs-To: \n"

-"POT-Creation-Date: 2024-07-29 16:42+0100\n"

+"POT-Creation-Date: 2024-08-21 12:27+0100\n"

 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"

 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"

 "Language-Team: LANGUAGE <LL@li.org>\n"

​

@@ -126,7 +126,7 @@

     profile = gst_structure_get_string (s, "profile");

     if (profile) {

-      if (!strcmp (profile, "main"))

+      if (!g_strcmp0 (profile, "main"))

         thiz->profile = MFX_PROFILE_AV1_MAIN;

       else

         g_assert_not_reached ();

​

@@ -130,8 +130,8 @@

       dev = (GUdevDevice *) l->data;

       parent = g_udev_device_get_parent (dev);

-      if (strcmp (g_udev_device_get_subsystem (parent), "pci") != 0 ||

-          strcmp (g_udev_device_get_driver (parent), "i915") != 0) {

+      if (g_strcmp0 (g_udev_device_get_subsystem (parent), "pci") != 0 ||

+          g_strcmp0 (g_udev_device_get_driver (parent), "i915") != 0) {

         g_object_unref (parent);

         continue;

       }

​

@@ -305,13 +305,13 @@

     profile = gst_structure_get_string (s, "profile");

     if (profile) {

-      if (!strcmp (profile, "high")) {

+      if (!g_strcmp0 (profile, "high")) {

         thiz->profile = MFX_PROFILE_AVC_HIGH;

-      } else if (!strcmp (profile, "main")) {

+      } else if (!g_strcmp0 (profile, "main")) {

         thiz->profile = MFX_PROFILE_AVC_MAIN;

-      } else if (!strcmp (profile, "baseline")) {

+      } else if (!g_strcmp0 (profile, "baseline")) {

         thiz->profile = MFX_PROFILE_AVC_BASELINE;

-      } else if (!strcmp (profile, "constrained-baseline")) {

+      } else if (!g_strcmp0 (profile, "constrained-baseline")) {

         thiz->profile = MFX_PROFILE_AVC_CONSTRAINED_BASELINE;

       } else {

         thiz->profile = MFX_PROFILE_UNKNOWN;

​

@@ -371,11 +371,11 @@

   if (h265enc->profile_name) {

     encoder->param.mfx.CodecProfile = MFX_PROFILE_HEVC_MAIN;

-    if (!strcmp (h265enc->profile_name, "main-10"))

+    if (!g_strcmp0 (h265enc->profile_name, "main-10"))

       encoder->param.mfx.CodecProfile = MFX_PROFILE_HEVC_MAIN10;

-    else if (!strcmp (h265enc->profile_name, "main-still-picture"))

+    else if (!g_strcmp0 (h265enc->profile_name, "main-still-picture"))

       encoder->param.mfx.CodecProfile = MFX_PROFILE_HEVC_MAINSP;

-    else if (!strcmp (h265enc->profile_name, "main-10-still-picture")) {

+    else if (!g_strcmp0 (h265enc->profile_name, "main-10-still-picture")) {

       encoder->param.mfx.CodecProfile = MFX_PROFILE_HEVC_MAIN10;

       h265enc->ext_param.Header.BufferId = MFX_EXTBUFF_HEVC_PARAM;

       h265enc->ext_param.Header.BufferSz = sizeof (h265enc->ext_param);

@@ -383,17 +383,16 @@

           MFX_HEVC_CONSTR_REXT_ONE_PICTURE_ONLY;

       gst_msdkenc_add_extra_param (encoder,

           (mfxExtBuffer *) & h265enc->ext_param);

-    } else if (!strcmp (h265enc->profile_name, "main-444") ||

-        !strcmp (h265enc->profile_name, "main-422-10") ||

-        !strcmp (h265enc->profile_name, "main-444-10") ||

-        !strcmp (h265enc->profile_name, "main-12"))

+    } else if (!g_strcmp0 (h265enc->profile_name, "main-444") ||

+        !g_strcmp0 (h265enc->profile_name, "main-422-10") ||

+        !g_strcmp0 (h265enc->profile_name, "main-444-10") ||

+        !g_strcmp0 (h265enc->profile_name, "main-12"))

       encoder->param.mfx.CodecProfile = MFX_PROFILE_HEVC_REXT;

-

 #if (MFX_VERSION >= 1032)

-    else if (!strcmp (h265enc->profile_name, "screen-extended-main") ||

-        !strcmp (h265enc->profile_name, "screen-extended-main-10") ||

-        !strcmp (h265enc->profile_name, "screen-extended-main-444") ||

-        !strcmp (h265enc->profile_name, "screen-extended-main-444-10"))

+    else if (!g_strcmp0 (h265enc->profile_name, "screen-extended-main") ||

+        !g_strcmp0 (h265enc->profile_name, "screen-extended-main-10") ||

+        !g_strcmp0 (h265enc->profile_name, "screen-extended-main-444") ||

+        !g_strcmp0 (h265enc->profile_name, "screen-extended-main-444-10"))

       encoder->param.mfx.CodecProfile = MFX_PROFILE_HEVC_SCC;

 #endif

   } else {

​

@@ -109,11 +109,11 @@

     profile = gst_structure_get_string (s, "profile");

     if (profile) {

-      if (!strcmp (profile, "high")) {

+      if (!g_strcmp0 (profile, "high")) {

         thiz->profile = MFX_PROFILE_MPEG2_HIGH;

-      } else if (!strcmp (profile, "main")) {

+      } else if (!g_strcmp0 (profile, "main")) {

         thiz->profile = MFX_PROFILE_MPEG2_MAIN;

-      } else if (!strcmp (profile, "simple")) {

+      } else if (!g_strcmp0 (profile, "simple")) {

         thiz->profile = MFX_PROFILE_MPEG2_SIMPLE;

       } else {

         g_assert_not_reached ();

​

@@ -97,9 +97,9 @@

   profile_str = gst_structure_get_string (structure, "profile");

-  if (!strcmp (profile_str, "simple"))

+  if (!g_strcmp0 (profile_str, "simple"))

     decoder->param.mfx.CodecProfile = MFX_PROFILE_VC1_SIMPLE;

-  else if (!strcmp (profile_str, "main"))

+  else if (!g_strcmp0 (profile_str, "main"))

     decoder->param.mfx.CodecProfile = MFX_PROFILE_VC1_MAIN;

   else {

     decoder->param.mfx.CodecProfile = MFX_PROFILE_VC1_ADVANCED;

​

@@ -113,13 +113,13 @@

     profile = gst_structure_get_string (s, "profile");

     if (profile) {

-      if (!strcmp (profile, "3")) {

+      if (!g_strcmp0 (profile, "3")) {

         thiz->profile = MFX_PROFILE_VP9_3;

-      } else if (!strcmp (profile, "2")) {

+      } else if (!g_strcmp0 (profile, "2")) {

         thiz->profile = MFX_PROFILE_VP9_2;

-      } else if (!strcmp (profile, "1")) {

+      } else if (!g_strcmp0 (profile, "1")) {

         thiz->profile = MFX_PROFILE_VP9_1;

-      } else if (!strcmp (profile, "0")) {

+      } else if (!g_strcmp0 (profile, "0")) {

         thiz->profile = MFX_PROFILE_VP9_0;

       } else {

         g_assert_not_reached ();

​

@@ -658,8 +658,7 @@

   if (!ret

       || (old_display && new_display && old_display != new_display

           && base->decoder)) {

-    GST_ELEMENT_WARNING (base, RESOURCE, BUSY,

-        ("Can't replace VA display while operating"), (NULL));

+    GST_WARNING_OBJECT (base, "Can't replace VA display while operating");

   }

   gst_clear_object (&old_display);

​

@@ -850,8 +850,7 @@

   if (!ret || (old_display && new_display && old_display != new_display

           && base->encoder)) {

-    GST_ELEMENT_WARNING (element, RESOURCE, BUSY,

-        ("Can't replace VA display while operating"), (NULL));

+    GST_WARNING_OBJECT (element, "Can't replace VA display while operating");

   }

   gst_clear_object (&old_display);

​

@@ -610,8 +610,7 @@

   if (!ret

       || (old_display && new_display && old_display != new_display

           && self->filter)) {

-    GST_ELEMENT_WARNING (element, RESOURCE, BUSY,

-        ("Can't replace VA display while operating"), (NULL));

+    GST_WARNING_OBJECT (element, "Can't replace VA display while operating");

   }

   gst_clear_object (&old_display);

​

@@ -420,8 +420,7 @@

   if (!ret

       || (old_display && new_display && old_display != new_display

           && self->filter)) {

-    GST_ELEMENT_WARNING (element, RESOURCE, BUSY,

-        ("Can't replace VA display while operating"), (NULL));

+    GST_WARNING_OBJECT (element, "Can't replace VA display while operating");

   }

   gst_clear_object (&old_display);

​

@@ -845,12 +845,14 @@

   assert_equals_int (ret, GST_H264_PARSER_ERROR);

   fail_unless (config == NULL);

-  /* wrong length size, return error with null config data */

+  /* wrong length size, since we still try to use it. so return ok */

   ret = gst_h264_parser_parse_decoder_config_record (parser,

       h264_wrong_length_size_codec_data,

       sizeof (h264_wrong_length_size_codec_data), &config);

-  assert_equals_int (ret, GST_H264_PARSER_ERROR);

-  fail_unless (config == NULL);

+  assert_equals_int (ret, GST_H264_PARSER_OK);

+  fail_unless (config != NULL);

+  assert_equals_int (config->length_size_minus_one, 2);

+  g_clear_pointer (&config, gst_h264_decoder_config_record_free);

   gst_h264_nal_parser_free (parser);

 }

​