@@ -1,4 +1,9 @@

 -------------------------------------------------------------------

+Wed Apr 16 08:10:32 UTC 2025 - Bjørn Lie <zaitor@opensuse.org>

+

+- Update to version 1.4.2

+

+-------------------------------------------------------------------

 Wed Mar 19 21:34:39 UTC 2025 - Bjørn Lie <zaitor@opensuse.org>

 - Update to version 1.4.1

​

@@ -8,7 +8,7 @@

 %define minimum_version 1.4.0

 Name:           pipewire-aptx

-Version:        1.4.1

+Version:        1.4.2

 Release:        0

 Summary:        PipeWire Bluetooth aptX codec plugin

 License:        MIT

​

@@ -2,6 +2,6 @@

   <service name="download_url">

     <param name="host">gitlab.freedesktop.org</param>

     <param name="protocol">https</param>

-    <param name="path">/pipewire/pipewire/-/archive/1.4.1/pipewire-1.4.1.tar.bz2</param>

+    <param name="path">/pipewire/pipewire/-/archive/1.4.2/pipewire-1.4.2.tar.bz2</param>

   </service>

 </services>

\ No newline at end of file

​

@@ -1,3 +1,37 @@

+# PipeWire 1.4.2 (2025-04-14)

+

+This is a bugfix release that is API and ABI compatible with

+previous 1.x releases.

+

+## Highlights

+  - Do extra checks for MIDI to avoid 100% CPU usage on older kernels.

+  - Fix some potential crashes in POD builder.

+  - pw-cat streaming improvements on stdout/stdin.

+  - Small fixes and improvements.

+

+

+## PipeWire

+  - Make the service files depend on DBus to avoid startup races.

+

+## SPA

+  - Do extra checks for MIDI to avoid 100% CPU usage on older kernels.

+  - Use Header metadata by default in videoadapter.

+  - Handle set_format result from v4l2 better.

+  - Handle crash when POD builder overflows in the filter.

+  - Work around a libebur128 bug. (#4646)

+

+## Tools

+  - pw-cat prefers AU format when streaming on stdout/stdin. (#4629)

+  - Improve pw-cat verbose sndfile format debug.

+  - Add the missing --channel-map long option to pw-loopback.

+

+## GStreamer

+  - Fix a leak in the deviceprovider. (#4616)

+  - Fix negotiation and make renegotiation better.

+

+

+Older versions:

+

 # PipeWire 1.4.1 (2025-03-14)

 This is a quick bugfix release that is API and ABI compatible with

@@ -35,9 +69,6 @@

 ## Bluetooth

   - Fix a crash with an incomming call.

-

-Older versions:

-

 # PipeWire 1.4.0 (2025-03-06)

 This is the 1.4 release that is API and ABI compatible with previous

​

@@ -37,7 +37,7 @@

 List output ports

 \par -i | \--input

-List output ports

+List input ports

 \par -l | \--links

 List links

​

@@ -1,5 +1,5 @@

 project('pipewire', 'c' ,

-  version : '1.4.1',

+  version : '1.4.2',

   license :  'MIT', 'LGPL-2.1-or-later', 'GPL-2.0-only' ,

   meson_version : '>= 0.61.1',

   default_options :  'warning_level=3',

​

@@ -139,7 +139,7 @@

        const struct spa_pod_prop *p2)

 {

    const struct spa_pod *v1, *v2;

-   struct spa_pod_choice *nc;

+   struct spa_pod_choice *nc, dummy;

    uint32_t j, k, nalt1, nalt2;

    void *alt1, *alt2, *a1, *a2;

    uint32_t type, size, p1c, p2c;

@@ -175,6 +175,10 @@

    spa_pod_builder_prop(b, p1->key, p1->flags & p2->flags);

    spa_pod_builder_push_choice(b, &f, 0, 0);

    nc = (struct spa_pod_choice*)spa_pod_builder_frame(b, &f);

+   /* write to dummy value when builder overflows. We don't want to error

+    * because overflowing is a way to determine the required buffer size. */

+   if (nc == NULL)

+       nc = &dummy;

    /* default value */

    spa_pod_builder_primitive(b, v1);

​

@@ -44,9 +44,27 @@

 #ifdef HAVE_ALSA_UMP

    res = snd_seq_set_client_midi_version(conn->hndl, SND_SEQ_CLIENT_UMP_MIDI_2_0);

+   if (!res) {

+       snd_seq_client_info_t *info = NULL;

+

+       /* Double check client version */

+       res = snd_seq_client_info_malloc(&info);

+       if (!res)

+           res = snd_seq_get_client_info(conn->hndl, info);

+       if (!res) {

+           res = snd_seq_client_info_get_midi_version(info);

+           if (res == SND_SEQ_CLIENT_UMP_MIDI_2_0)

+               res = 0;

+           else

+               res = -EIO;

+       }

+       if (info)

+           snd_seq_client_info_free(info);

+   }

 #else

    res = -EOPNOTSUPP;

 #endif

+

    if (res < 0) {

        spa_log_lev(state->log, (probe_ump ? SPA_LOG_LEVEL_INFO : SPA_LOG_LEVEL_ERROR),

                "%p: ALSA failed to enable UMP MIDI: %s", state, snd_strerror(res));

​

@@ -997,6 +997,8 @@

    format = merge_objects(this, &b, SPA_PARAM_Format,

            (struct spa_pod_object*)format,

            (struct spa_pod_object*)def);

+   if (format == NULL)

+       return -ENOSPC;

    spa_pod_fixate(format);

@@ -1612,13 +1614,13 @@

    uint32_t count = 0;

    struct spa_result_node_params result;

-   spa_pod_builder_init(&b, buffer, sizeof(buffer));

-

    result.id = id;

    result.next = start;

 next:

    result.index = result.next;

+   spa_pod_builder_init(&b, buffer, sizeof(buffer));

+

    if (result.next < 0x100000) {

        /* Enumerate follower formats first, until we have enough or we run out */

        if ((res = node_port_enum_params_sync(this, this->follower, direction, port_id, id,

​

@@ -1214,7 +1214,7 @@

    while (true) {

        const char *name;

        struct spa_pod *pod;

-       char value512;

+       char value4096;

        if (spa_pod_parser_get_string(&prs, &name) < 0)

            break;

​

@@ -235,6 +235,8 @@

 static void ebur128_activate(void * Instance)

 {

    struct ebur128_impl *impl = Instance;

+   unsigned long max_window;

+   int major, minor, patch;

    int mode = 0, i;

    int modes = {

        EBUR128_MODE_M,

@@ -264,12 +266,17 @@

            mode |= modesi;

    }

+   ebur128_get_version(&major, &minor, &patch);

+   max_window = impl->max_window;

+   if (major == 1 && minor == 2 && (patch == 5 || patch == 6))

+       max_window = (max_window + 999) / 1000;

+

    for (i = 0; i < 7; i++) {

        impl->sti = ebur128_init(1, impl->rate, mode);

        if (impl->sti) {

            ebur128_set_channel(impl->sti, i, channelsi);

            ebur128_set_max_history(impl->sti, impl->max_history);

-           ebur128_set_max_window(impl->sti, impl->max_window);

+           ebur128_set_max_window(impl->sti, max_window);

        }

    }

 }

​

@@ -675,7 +675,7 @@

               const struct spa_pod *format)

 {

    struct spa_video_info info;

-   int res;

+   int res = 0;

    spa_zero(info);

@@ -755,7 +755,7 @@

    emit_port_info(this, port, false);

    emit_node_info(this, false);

-   return 0;

+   return res;

 }

 static int impl_node_port_set_param(void *object,

​

@@ -403,6 +403,7 @@

    uint32_t i, size, buffers, blocks, align, flags, stride = 0;

    uint32_t *aligns;

    struct spa_data *datas;

+   struct spa_meta metas1;

    uint64_t follower_flags, conv_flags;

    spa_log_debug(this->log, "%p: n_buffers:%d", this, this->n_buffers);

@@ -484,9 +485,11 @@

        datasi.maxsize = size;

        alignsi = align;

    }

+   metas0.type = SPA_META_Header;

+   metas0.size = sizeof(struct spa_meta_header);

    free(this->buffers);

-   this->buffers = spa_buffer_alloc_array(buffers, flags, 0, NULL, blocks, datas, aligns);

+   this->buffers = spa_buffer_alloc_array(buffers, flags, 1, metas, blocks, datas, aligns);

    if (this->buffers == NULL)

        return -errno;

    this->n_buffers = buffers;

@@ -961,6 +964,8 @@

    format = merge_objects(this, &b, SPA_PARAM_Format,

            (struct spa_pod_object*)format,

            (struct spa_pod_object*)def);

+   if (format == NULL)

+       return -ENOSPC;

    spa_pod_fixate(format);

​

@@ -11,6 +11,12 @@

 systemd_config.set('PW_BINARY', pipewire_bindir / 'pipewire')

 systemd_config.set('PW_PULSE_BINARY', pipewire_bindir / 'pipewire-pulse')

+pw_service_reqs = ''

+if get_option('dbus').enabled()

+  pw_service_reqs += 'dbus.service '

+endif

+systemd_config.set('PW_SERVICE_REQS', pw_service_reqs)

+

 configure_file(input : 'pipewire.service.in',

                output : 'pipewire.service',

                configuration : systemd_config,

​

@@ -13,7 +13,7 @@

 #

 # After=pipewire.socket is not needed, as it is already implicit in the

 # socket-service relationship, see systemd.socket(5).

-Requires=pipewire.socket

+Requires=pipewire.socket @PW_SERVICE_REQS@

 ConditionUser=!root

 Service

​

@@ -327,6 +327,7 @@

                                             gst_object_ref_sink (device),

                                             compare_device_session_priority);

     } else {

+      gst_object_ref (device);

       gst_device_provider_device_add (GST_DEVICE_PROVIDER (self), device);

     }

   }

@@ -484,7 +485,8 @@

   }

   if (nd->dev != NULL) {

-    gst_device_provider_device_remove (provider, GST_DEVICE (nd->dev));

+    gst_device_provider_device_remove (provider, nd->dev);

+    gst_clear_object (&nd->dev);

   }

   if (nd->caps)

     gst_caps_unref(nd->caps);

​

@@ -1065,8 +1065,19 @@

     {

       if (n_items < 3)

         return;

-      gst_caps_set_simple (res, width, GST_TYPE_INT_RANGE, rect1.width, rect2.width,

-                                height, GST_TYPE_INT_RANGE, rect1.height, rect2.height, NULL);

+

+      if (rect1.width == rect2.width &&

+          rect1.height == rect2.height) {

+        gst_caps_set_simple (res,

+            width, G_TYPE_INT, rect1.width,

+            height, G_TYPE_INT, rect1.height,

+            NULL);

+      } else {

+        gst_caps_set_simple (res,

+            width, GST_TYPE_INT_RANGE, rect1.width, rect2.width,

+            height, GST_TYPE_INT_RANGE, rect1.height, rect2.height,

+            NULL);

+      }

       break;

     }

     case SPA_CHOICE_Enum:

@@ -1117,8 +1128,17 @@

     {

       if (n_items < 3)

         return;

-      gst_caps_set_simple (res, key, GST_TYPE_FRACTION_RANGE, fract1.num, fract1.denom,

-                                                              fract2.num, fract2.denom, NULL);

+

+      if (fract1.num == fract2.num &&

+          fract1.denom == fract2.denom) {

+        gst_caps_set_simple (res, key, GST_TYPE_FRACTION,

+            fract1.num, fract1.denom, NULL);

+      } else {

+        gst_caps_set_simple (res, key, GST_TYPE_FRACTION_RANGE,

+            fract1.num, fract1.denom,

+            fract2.num, fract2.denom,

+            NULL);

+      }

       break;

     }

     case SPA_CHOICE_Enum:

​

@@ -305,6 +305,7 @@

   struct spa_pod_builder b = { NULL };

   uint8_t buffer1024;

   struct spa_pod_frame f;

+  guint n_params = 0;

   config = gst_buffer_pool_get_config (GST_BUFFER_POOL (pool));

   gst_buffer_pool_config_get_params (config, &caps, &size, &min_buffers, &max_buffers);

@@ -325,20 +326,22 @@

                                                 (1<<SPA_DATA_MemFd) |

                                                 (1<<SPA_DATA_MemPtr)),

       0);

-  port_params0 = spa_pod_builder_pop (&b, &f);

+  port_paramsn_params++ = spa_pod_builder_pop (&b, &f);

-  port_params1 = spa_pod_builder_add_object (&b,

+  port_paramsn_params++ = spa_pod_builder_add_object (&b,

       SPA_TYPE_OBJECT_ParamMeta, SPA_PARAM_Meta,

       SPA_PARAM_META_type, SPA_POD_Id(SPA_META_Header),

       SPA_PARAM_META_size, SPA_POD_Int(sizeof (struct spa_meta_header)));

-  port_params2 = spa_pod_builder_add_object (&b,

-      SPA_TYPE_OBJECT_ParamMeta, SPA_PARAM_Meta,

-      SPA_PARAM_META_type, SPA_POD_Id(SPA_META_VideoCrop),

-      SPA_PARAM_META_size, SPA_POD_Int(sizeof (struct spa_meta_region)));

+  if (sink->is_video) {

+    port_paramsn_params++ = spa_pod_builder_add_object (&b,

+        SPA_TYPE_OBJECT_ParamMeta, SPA_PARAM_Meta,

+        SPA_PARAM_META_type, SPA_POD_Id(SPA_META_VideoCrop),

+        SPA_PARAM_META_size, SPA_POD_Int(sizeof (struct spa_meta_region)));

+  }

   pw_thread_loop_lock (sink->stream->core->loop);

-  pw_stream_update_params (sink->stream->pwstream, port_params, 3);

+  pw_stream_update_params (sink->stream->pwstream, port_params, n_params);

   pw_thread_loop_unlock (sink->stream->core->loop);

 }

​

@@ -1091,14 +1091,34 @@

   }

   pw_peer_caps = gst_caps_from_format (param);

+

   if (pw_peer_caps && pwsrc->possible_caps) {

+    GST_DEBUG_OBJECT (pwsrc, "peer caps %" GST_PTR_FORMAT, pw_peer_caps);

+    GST_DEBUG_OBJECT (pwsrc, "possible caps %" GST_PTR_FORMAT, pwsrc->possible_caps);

+

     pwsrc->caps = gst_caps_intersect_full (pw_peer_caps,

                                            pwsrc->possible_caps,

                                            GST_CAPS_INTERSECT_FIRST);

+

+  /*

+   * We expect pw_peer_caps to be fixed caps as we receive that from

+   * PipeWire. See pw_context_find_format() and SPA_PARAM_Format.

+   * possible_caps can be non-fixated caps based on what is downstream

+   * in the pipeline.

+   *

+   * The intersection result above might give us non-fixated caps. A

+   * possible scenario for this is the below pipeline.

+   * pipewiresrc ! audioconvert ! audio/x-raw,rate=44100,channels=2 ! ..

+   *

+   * So we fixate the caps explicitly here.

+   */

+    pwsrc->caps = gst_caps_fixate (pwsrc->caps);

     gst_caps_maybe_fixate_dma_format (pwsrc->caps);

   }

-  if (pwsrc->caps && gst_caps_is_fixed (pwsrc->caps)) {

+  if (pwsrc->caps) {

+    g_return_if_fail (gst_caps_is_fixed (pwsrc->caps));

+

     pwsrc->negotiated = TRUE;

     structure = gst_caps_get_structure (pwsrc->caps, 0);

@@ -1127,14 +1147,15 @@

 #ifdef HAVE_GSTREAMER_DMA_DRM

       }

 #endif

+    } else {

+      /* Don't provide bufferpool for audio if not requested by the

+       * application/user */

+      if (pwsrc->use_bufferpool != USE_BUFFERPOOL_YES)

+        pwsrc->use_bufferpool = USE_BUFFERPOOL_NO;

     }

   } else {

     pwsrc->negotiated = FALSE;

     pwsrc->is_video = FALSE;

-

-    /* Don't provide bufferpool for audio if not requested by the application/user */

-    if (pwsrc->use_bufferpool != USE_BUFFERPOOL_YES)

-      pwsrc->use_bufferpool = USE_BUFFERPOOL_NO;

   }

   if (pwsrc->caps) {

@@ -1158,7 +1179,7 @@

                                                             pwsrc->min_buffers,

                                                             pwsrc->max_buffers),

         SPA_PARAM_BUFFERS_blocks,  SPA_POD_CHOICE_RANGE_Int(0, 1, INT32_MAX),

-        SPA_PARAM_BUFFERS_size,    SPA_POD_CHOICE_RANGE_Int(0, 0, INT32_MAX),

+        SPA_PARAM_BUFFERS_size,    SPA_POD_CHOICE_RANGE_Int(0, 1, INT32_MAX),

         SPA_PARAM_BUFFERS_stride,  SPA_POD_CHOICE_RANGE_Int(0, 0, INT32_MAX),

         SPA_PARAM_BUFFERS_dataType, SPA_POD_CHOICE_FLAGS_Int(buffertypes));

​

@@ -1331,10 +1331,12 @@

 static int rtsp_do_post_auth_setup(struct impl *impl)

 {

-   static const unsigned char content33 =

-       "\x01"

-       "\x59\x02\xed\xe9\x0d\x4e\xf2\xbd\x4c\xb6\x8a\x63\x30\x03\x82\x07"

-       "\xa9\x4d\xbd\x50\xd8\xaa\x46\x5b\x5d\x8c\x01\x2a\x0c\x7e\x1d\x4e";

+   static const uint8_t content33 = {

+       0x01,

+       0x59, 0x02, 0xed, 0xe9, 0x0d, 0x4e, 0xf2, 0xbd,

+       0x4c, 0xb6, 0x8a, 0x63, 0x30, 0x03, 0x82, 0x07,

+       0xa9, 0x4d, 0xbd, 0x50, 0xd8, 0xaa, 0x46, 0x5b,

+       0x5d, 0x8c, 0x01, 0x2a, 0x0c, 0x7e, 0x1d, 0x4e };

    return pw_rtsp_client_url_send(impl->rtsp, "/auth-setup", "POST", &impl->headers->dict,

                       "application/octet-stream", content, sizeof(content),

​

@@ -388,11 +388,10 @@

        }

    }

-   pw_log_pod(SPA_LOG_LEVEL_DEBUG, format);

-

    SPA_POD_OBJECT_ID(format) = SPA_PARAM_Format;

    pw_log_debug("%p: doing set format %p fixated:%d", this,

            format, spa_pod_is_fixated(format));

+   pw_log_pod(SPA_LOG_LEVEL_INFO, format);

    if (out_state == PW_IMPL_PORT_STATE_CONFIGURE) {

        pw_log_debug("%p: doing set format on output", this);

@@ -405,7 +404,7 @@

            goto error;

        }

        if (SPA_RESULT_IS_ASYNC(res)) {

-           pw_log_info("output set format %d", res);

+           pw_log_debug("output set format %d", res);

            busy_id = pw_work_queue_add(impl->work, &this->output_link,

                    spa_node_sync(output->node->node, res),

                    complete_ready, this);

@@ -425,7 +424,7 @@

            goto error;

        }

        if (SPA_RESULT_IS_ASYNC(res2)) {

-           pw_log_info("input set format %d", res2);

+           pw_log_debug("input set format %d", res2);

            busy_id = pw_work_queue_add(impl->work, &this->input_link,

                    spa_node_sync(input->node->node, res2),

                    complete_ready, this);

​

@@ -1343,7 +1343,7 @@

        }

    }

    if (format == -1)

-       format = SF_FORMAT_WAV;

+       format = spa_streq(filename, "-") ? SF_FORMAT_AU : SF_FORMAT_WAV;

    if (format == SF_FORMAT_WAV && info->channels > 2)

        format = SF_FORMAT_WAVEX;

@@ -1436,6 +1436,21 @@

 }

 #endif

+static const char *endianness_to_name(int format)

+{

+   switch (format & SF_FORMAT_ENDMASK) {

+   case SF_ENDIAN_FILE:

+       return "Default Endian";

+   case SF_ENDIAN_LITTLE:

+       return "Little Endian";

+   case SF_ENDIAN_BIG:

+       return "Big Endian";

+   case SF_ENDIAN_CPU:

+       return "CPU Endian";

+   }

+   return "unknown";

+}

+

 static int setup_sndfile(struct data *data)

 {

    const struct format_info *fi = NULL;

@@ -1473,9 +1488,21 @@

        return -EIO;

    }

-   if (data->verbose)

-       fprintf(stderr, "sndfile: opened file \"%s\" format %08x channels:%d rate:%d\n",

-               data->filename, info.format, info.channels, info.samplerate);

+   if (data->verbose) {

+       SF_FORMAT_INFO ti, sti;

+       spa_zero(ti);

+       ti.format = info.format & SF_FORMAT_TYPEMASK;

+       if (sf_command(NULL, SFC_GET_FORMAT_INFO, &ti, sizeof(ti)) != 0)

+           ti.name = "unknown";

+       spa_zero(sti);

+       sti.format = info.format & SF_FORMAT_SUBMASK;

+       if (sf_command(NULL, SFC_GET_FORMAT_INFO, &sti, sizeof(sti)) != 0)

+           sti.name = "unknown";

+

+       fprintf(stderr, "sndfile: opened file \"%s\" format \"%s %s %s\" channels:%d rate:%d\n",

+               data->filename, endianness_to_name(info.format),

+               ti.name, sti.name, info.channels, info.samplerate);

+   }

    if (data->channels > 0 && info.channels != (int)data->channels) {

        fprintf(stderr, "sndfile: given channels (%u) don't match file channels (%d)\n",

                data->channels, info.channels);

@@ -1511,7 +1538,6 @@

        /* try native format first, else decode to float */

        if ((fi = format_info_by_sf_format(info.format)) == NULL)

            fi = format_info_by_sf_format(SF_FORMAT_FLOAT);

-

    }

    if (fi == NULL)

        return -EIO;

​

@@ -103,6 +103,7 @@

        { "group",      required_argument,  NULL, 'g' },

        { "name",       required_argument,  NULL, 'n' },

        { "channels",       required_argument,  NULL, 'c' },

+       { "channel-map",    required_argument,  NULL, 'm' },

        { "latency",        required_argument,  NULL, 'l' },

        { "delay",      required_argument,  NULL, 'd' },

        { "capture",        required_argument,  NULL, 'C' },

​