Projects
Staging
vlc-beta
Sign Up
Log In
Username
Password
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
Expand all
Collapse all
Changes of Revision 405
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/meson.build -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/meson.build
Changed
@@ -1064,9 +1064,13 @@ # VLC plugins subdir('modules') -# Integration and non-regression tests, some unittest are there too but the -# modules/, src/ and lib/ folders should be favoured for those. -subdir('test') +if (get_option('tests') + .disable_auto_if(host_system in 'windows') + .allowed()) + # Integration and non-regression tests, some unittest are there too but the + # modules/, src/ and lib/ folders should be favoured for those. + subdir('test') +endif if get_option('rust').allowed() warning('''
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/meson_options.txt -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/meson_options.txt
Changed
@@ -5,6 +5,11 @@ value : true, description : 'Build the VLC executable program.') +option('tests', + type : 'feature', + value : 'auto', + description : 'Build the VLC test executables.') + option('nls', type : 'feature', value : 'auto',
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/codec/dav1d.c -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/codec/dav1d.c
Changed
@@ -115,14 +115,14 @@ img->seq_hdr->pri == DAV1D_COLOR_PRI_BT709 && img->seq_hdr->trc == DAV1D_TRC_SRGB ) { - if( img->seq_hdr->hbd < 0 || img->seq_hdr->hbd >= (int)ARRAY_SIZE(chroma_table_rgb) ) + if( img->seq_hdr->hbd >= (int)ARRAY_SIZE(chroma_table_rgb) ) return 0; return chroma_table_rgbimg->seq_hdr->hbd; } if( img->seq_hdr->layout < 0 || img->seq_hdr->layout >= (int)ARRAY_SIZE(chroma_table) ) return 0; - if( img->seq_hdr->hbd < 0 || img->seq_hdr->hbd >= (int)ARRAY_SIZE(chroma_table0) ) + if( img->seq_hdr->hbd >= (int)ARRAY_SIZE(chroma_table0) ) return 0; return chroma_tableimg->seq_hdr->layoutimg->seq_hdr->hbd;
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/gui/qt/Makefile.am -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/gui/qt/Makefile.am
Changed
@@ -27,6 +27,7 @@ libqt_plugin_la_CPPFLAGS = $(AM_CPPFLAGS) $(CPPFLAGS_qt) \ -DQT_STRICT_ITERATORS \ + -DQT_USE_QSTRINGBUILDER \ -I$(srcdir) -I$(builddir) \ -I$(builddir)/dialogs/extended \ -I$(builddir)/dialogs/fingerprint \
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/gui/qt/dialogs/help/help.cpp -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/gui/qt/dialogs/help/help.cpp
Changed
@@ -389,7 +389,7 @@ .arg( m_model->getMajor() ) .arg( m_model->getMinor() ) .arg( m_model->getRevision() ) - .arg( extra == 0 ? "" : "." + QString::number( extra ) ); + .arg( extra == 0 ? QStringLiteral("") : QStringLiteral(".") + QString::number( extra ) ); ui.updateNotifyLabel->setText( message ); message = m_model->getDescription().replace( "\n", "<br/>" );
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/gui/qt/dialogs/sout/convert.cpp -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/gui/qt/dialogs/sout/convert.cpp
Changed
@@ -156,7 +156,7 @@ void ConvertDialog::fileBrowse() { - QString fileExtension = ( ! profile->isEnabled() ) ? ".*" : "." + profile->getMux(); + QString fileExtension = ( ! profile->isEnabled() ) ? QStringLiteral(".*") : QStringLiteral(".") + profile->getMux(); outgoingMRL = QFileDialog::getSaveFileUrl( this, qtr( "Save file..." ), p_intf->p_mi->getDialogFilePath(), @@ -203,7 +203,7 @@ // Multiple, use the convention. else { - QString fileExtension = ( ! profile->isEnabled() ) ? ".*" : "." + profile->getMux(); + QString fileExtension = ( ! profile->isEnabled() ) ? QStringLiteral(".*") : QStringLiteral(".") + profile->getMux(); newFileName = incomingMRLs->at(i);
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/gui/qt/maininterface/compositor.cpp -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/gui/qt/maininterface/compositor.cpp
Changed
@@ -272,7 +272,16 @@ } if (!backendIsOpenVg && (flags & CompositorVideo::HAS_ACRYLIC)) { - setBlurBehind(window, true); + if (Q_LIKELY(!window->isActive())) + { + connect(window, &QWindow::activeChanged, this, this, window = QPointer(window)() { + setBlurBehind(window, true); + }, Qt::SingleShotConnection); + } + else + { + setBlurBehind(window, true); + } } m_videoWindowHandler = std::make_unique<VideoWindowHandler>(m_intf); m_videoWindowHandler->setWindow( window ); @@ -282,7 +291,6 @@ #else m_interfaceWindowHandler = std::make_unique<InterfaceWindowHandler>(m_intf, m_mainCtx, window); #endif - m_mainCtx->setHasAcrylicSurface(m_blurBehind); m_mainCtx->setWindowSuportExtendedFrame(flags & CompositorVideo::HAS_EXTENDED_FRAME); #ifdef _WIN32 @@ -325,6 +333,7 @@ m_taskbarWidget.reset(); #endif m_interfaceWindowHandler.reset(); + m_mainCtx = nullptr; } void CompositorVideo::commonIntfDestroy() @@ -376,6 +385,6 @@ return false; m_windowEffectsModule->setBlurBehind(window, enable); - m_blurBehind = enable; + m_mainCtx->setHasAcrylicSurface(enable); return true; }
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/gui/qt/maininterface/compositor.hpp -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/gui/qt/maininterface/compositor.hpp
Changed
@@ -187,7 +187,6 @@ std::unique_ptr<WinTaskbarWidget> m_taskbarWidget; #endif - bool m_blurBehind = false; WindowEffectsModule* m_windowEffectsModule = nullptr; bool m_failedToLoadWindowEffectsModule = false; };
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/gui/qt/maininterface/compositor_dcomp.cpp -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/gui/qt/maininterface/compositor_dcomp.cpp
Changed
@@ -106,6 +106,8 @@ CompositorDirectComposition::~CompositorDirectComposition() { + //m_acrylicSurface should be released before the RHI context is destroyed + assert(!m_acrylicSurface); destroyMainInterface(); } @@ -213,19 +215,18 @@ m_dcompDevice->Commit(); - if (!m_blurBehind) + if (!m_mainCtx->hasAcrylicSurface()) { if (var_InheritBool(m_intf, "qt-backdrop-blur")) { try { - m_acrylicSurface = new CompositorDCompositionAcrylicSurface(m_intf, this, m_mainCtx, m_dcompDevice); + m_acrylicSurface = std::make_unique<CompositorDCompositionAcrylicSurface>(m_intf, this, m_mainCtx, m_dcompDevice); } catch (const std::exception& exception) { if (const auto what = exception.what()) msg_Warn(m_intf, "%s", what); - delete m_acrylicSurface.data(); } } } @@ -303,6 +304,7 @@ void CompositorDirectComposition::unloadGUI() { + m_acrylicSurface.reset(); m_interfaceWindowHandler.reset(); m_quickView.reset(); commonGUIDestroy(); @@ -393,7 +395,7 @@ static_cast<QPlatformSurfaceEvent *>(event)->surfaceEventType() == QPlatformSurfaceEvent::SurfaceAboutToBeDestroyed) { m_videoVisual.Reset(); - delete m_acrylicSurface.data(); + m_acrylicSurface.reset(); // Just in case root visual deletes its children // when it is deleted: (Qt's UI visual should be // deleted by Qt itself)
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/gui/qt/maininterface/compositor_dcomp.hpp -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/gui/qt/maininterface/compositor_dcomp.hpp
Changed
@@ -34,7 +34,6 @@ class MainCtx; class WinTaskbarWidget; - class QQuickView; class IDCompositionVisual; @@ -43,6 +42,8 @@ namespace vlc { +class CompositorDCompositionAcrylicSurface; + class CompositorDirectComposition : public CompositorVideo { Q_OBJECT @@ -96,7 +97,7 @@ Microsoft::WRL::ComPtr<IDCompositionVisual> m_videoVisual; IDCompositionVisual *m_uiVisual = nullptr; - QPointer<class CompositorDCompositionAcrylicSurface> m_acrylicSurface; + std::unique_ptr<CompositorDCompositionAcrylicSurface> m_acrylicSurface; }; }
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/gui/qt/maininterface/compositor_x11.cpp -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/gui/qt/maininterface/compositor_x11.cpp
Changed
@@ -209,7 +209,7 @@ m_qmlView->show(); - if (m_blurBehind) + if (m_mainCtx->hasAcrylicSurface()) m_renderWindow->m_hasAcrylic = true; m_renderWindow->setInterfaceWindow(m_qmlView.get());
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/gui/qt/maininterface/mainctx.hpp -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/gui/qt/maininterface/mainctx.hpp
Changed
@@ -211,7 +211,7 @@ inline bool isShowRemainingTime() const { return m_showRemainingTime; } inline double getIntfScaleFactor() const { return m_intfScaleFactor; } inline double getIntfUserScaleFactor() const { return m_intfUserScaleFactor; } - inline int CSDBorderSize() const { return 5 * getIntfScaleFactor(); } + inline int CSDBorderSize() const { return 10; } inline double getMinIntfUserScaleFactor() const { return MIN_INTF_USER_SCALE_FACTOR; } inline double getMaxIntfUserScaleFactor() const { return MAX_INTF_USER_SCALE_FACTOR; } inline bool hasMediaLibrary() const { return b_hasMedialibrary; }
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/gui/qt/maininterface/qml/MainInterface.qml -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/gui/qt/maininterface/qml/MainInterface.qml
Changed
@@ -100,7 +100,7 @@ Binding { target: MainCtx property: "windowExtendedMargin" - value: _extendedFrameVisible ? VLCStyle.dp(20, VLCStyle.scale) : 0 + value: _extendedFrameVisible ? 20 : 0 } Window.onWindowChanged: {
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/gui/qt/meson.build -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/gui/qt/meson.build
Changed
@@ -7,7 +7,7 @@ qt_include_dir = include_directories('.') qt_extra_deps = -qt_extra_flags = '-DQT_STRICT_ITERATORS' +qt_extra_flags = '-DQT_STRICT_ITERATORS','-DQT_USE_QSTRINGBUILDER' qt_cppargs = qt_link_args =
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/gui/qt/playlist/qml/PlaylistDelegate.qml -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/gui/qt/playlist/qml/PlaylistDelegate.qml
Changed
@@ -64,7 +64,7 @@ hoverEnabled: true - verticalPadding: VLCStyle.playlistDelegate_verticalPadding + verticalPadding: VLCStyle.margin_xxxsmall leftPadding: VLCStyle.margin_normal @@ -200,29 +200,25 @@ Layout.fillWidth: true Layout.fillHeight: true Layout.leftMargin: VLCStyle.margin_large - spacing: VLCStyle.margin_xsmall + spacing: VLCStyle.margin_xxxsmall Widgets.ListLabel { id: textInfo - Layout.fillHeight: true Layout.fillWidth: true font.weight: model.isCurrent ? Font.Bold : Font.DemiBold text: model.title color: theme.fg.primary - verticalAlignment: Text.AlignTop } Widgets.ListSubtitleLabel { id: textArtist - Layout.fillHeight: true Layout.fillWidth: true text: model.artist || qsTr("Unknown Artist") color: theme.fg.primary - verticalAlignment: Text.AlignBottom } }
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/gui/qt/qt.cpp -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/gui/qt/qt.cpp
Changed
@@ -1145,17 +1145,18 @@ VLCDialogModel::killInstance(); DialogErrorModel::killInstance(); + //destroy MainCtx, Compositor shouldn't not use MainCtx after `unloadGUI` + if (p_intf->p_mi) { + delete p_intf->p_mi; + p_intf->p_mi = nullptr; + } + if ( p_intf->p_compositor && cleanupReason == CLEANUP_APP_TERMINATED) { p_intf->p_compositor.reset(); - //destroy MainCtx - delete p_intf->p_mi; - p_intf->p_mi = nullptr; - delete p_intf->mainSettings; p_intf->mainSettings = nullptr; - } /* Destroy the main playlist controller */
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/gui/qt/style/VLCStyle.qml -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/gui/qt/style/VLCStyle.qml
Changed
@@ -232,8 +232,6 @@ readonly property int artistBanner_height: MainCtx.dp(200, scale) - readonly property int playlistDelegate_verticalPadding: MainCtx.dp(6, scale) - //global application size, updated by the root widget property int appWidth: 0 property int appHeight: 0
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/gui/qt/widgets/native/roundimage.cpp -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/gui/qt/widgets/native/roundimage.cpp
Changed
@@ -229,9 +229,15 @@ if (m_imageResponse) { if (m_cancelOnDelete) + { + disconnect(m_imageResponse, &QQuickImageResponse::finished, this, &RoundImageRequest::handleImageResponseFinished); + connect(m_imageResponse, &QQuickImageResponse::finished, m_imageResponse, &QObject::deleteLater); m_imageResponse->cancel(); - - m_imageResponse->deleteLater(); + } + else + { + m_imageResponse->deleteLater(); + } } g_imageCache.removeRequest(m_key); }
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/video_chroma/meson.build -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/video_chroma/meson.build
Changed
@@ -129,24 +129,24 @@ ## Tests -if host_system != 'windows' # can't use alarm # Chroma copy SSE test -chroma_copy_sse_test = executable( - 'chroma_copy_sse_test', - chroma_copy_lib_srcs, - c_args: '-DCOPY_TEST', - dependencies: libvlccore_dep, - include_directories: vlc_include_dirs -) -test('chroma_copy_sse', chroma_copy_sse_test, suite: 'video_chroma') +vlc_tests += { + 'name': 'chroma_copy_sse_test', + 'sources': chroma_copy_lib_srcs, + 'suite' : 'video_chroma', + 'c_args': '-DCOPY_TEST', + 'link_with': vlc_libcompat, + 'dependencies': libvlccore_dep, + 'include_directories': vlc_include_dirs +} # Chroma copy test -chroma_copy_test = executable( - 'chroma_copy_test', - chroma_copy_lib_srcs, - c_args: '-DCOPY_TEST', '-DCOPY_TEST_NOOPTIM', - dependencies: libvlccore_dep, - include_directories: vlc_include_dirs -) -test('chroma_copy', chroma_copy_test, suite: 'video_chroma') -endif +vlc_tests += { + 'name': 'chroma_copy_test', + 'sources': chroma_copy_lib_srcs, + 'suite' : 'video_chroma', + 'c_args': '-DCOPY_TEST', '-DCOPY_TEST_NOOPTIM', + 'link_with': vlc_libcompat, + 'dependencies': libvlccore_dep, + 'include_directories': vlc_include_dirs +}
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/modules/video_output/win32/direct3d11.cpp -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/modules/video_output/win32/direct3d11.cpp
Changed
@@ -1662,7 +1662,12 @@ picture_t *quad_picture = (*region)i; d3d11_quad_t *quad; if (quad_picture != NULL) + { quad = static_cast<d3d11_quad_t*>(quad_picture->p_sys); + + video_format_Clean(&quad->quad_fmt); + video_format_Copy(&quad->quad_fmt, &r->p_picture->format); + } else { d3d11_quad_t *d3dquad = new (std::nothrow) d3d11_quad_t;
View file
_service:obs_scm:vlc-beta-20241021.e009cc4da6.obscpio/src/preparser/fetcher.c -> _service:obs_scm:vlc-beta-20241028.0450706563.obscpio/src/preparser/fetcher.c
Changed
@@ -94,10 +94,7 @@ else if (executor == fetcher->executor_network) task->runnable.run = RunSearchNetwork; else - { - assert(executor == fetcher->executor_downloader); task->runnable.run = RunDownloader; - } task->runnable.userdata = task; @@ -460,21 +457,19 @@ return NULL; } - fetcher->executor_downloader = vlc_executor_New(max_threads); - if (!fetcher->executor_downloader) - { - if (fetcher->executor_network) - vlc_executor_Delete(fetcher->executor_network); - if (fetcher->executor_local) - vlc_executor_Delete(fetcher->executor_local); - free(fetcher); - return NULL; - } } else - { fetcher->executor_network = NULL; - fetcher->executor_downloader = NULL; + + fetcher->executor_downloader = vlc_executor_New(max_threads); + if (!fetcher->executor_downloader) + { + if (fetcher->executor_network) + vlc_executor_Delete(fetcher->executor_network); + if (fetcher->executor_local) + vlc_executor_Delete(fetcher->executor_local); + free(fetcher); + return NULL; } fetcher->owner = owner; @@ -533,8 +528,8 @@ vlc_executor_Delete(fetcher->executor_local); if (fetcher->executor_network) vlc_executor_Delete(fetcher->executor_network); - if (fetcher->executor_downloader) - vlc_executor_Delete(fetcher->executor_downloader); + assert(fetcher->executor_downloader); + vlc_executor_Delete(fetcher->executor_downloader); vlc_dictionary_clear( &fetcher->album_cache, FreeCacheEntry, NULL ); free( fetcher );
View file
_service:obs_scm:vlc-beta.obsinfo
Changed
@@ -1,4 +1,4 @@ name: vlc-beta -version: 20241021.e009cc4da6 -mtime: 1729484057 -commit: e009cc4da6689f648d5fe32d500b0a6f16adeeb8 +version: 20241028.0450706563 +mtime: 1730092262 +commit: 0450706563e262c5728ff159241ec276fc359969
Locations
Projects
Search
Status Monitor
Help
Open Build Service
OBS Manuals
API Documentation
OBS Portal
Reporting a Bug
Contact
Mailing List
Forums
Chat (IRC)
Twitter
Open Build Service (OBS)
is an
openSUSE project
.