File deadbeef-compiler-warnings.patch of Package deadbeef

File deadbeef-compiler-warnings.patch of Package deadbeef (Revision a8539f783869d7bd29367d235ee32a17)

Currently displaying revision a8539f783869d7bd29367d235ee32a17 , Show latest

[  168s] I: A function overflows or underflows an array access. This could be a real error,
[  168s]    but occasionaly this condition is also misdetected due to loop unrolling or strange pointer
[  168s]    handling. So this is warning only, please review.
[  168s] W: deadbeef arraysubscript dumb-kode54/src/it/readdsmf.c:32
[  168s] W: deadbeef arraysubscript game-music-emu-0.6pre/gme/Spc_Cpu.cpp:403, 404
[  168s] 
[  168s] I: Program causes undefined operation
[  168s]    (likely same variable used twiceand post/pre incremented in the same expression).
[  168s]    e.g. x = x++; Split it in two operations.
[  168s] W: deadbeef sequence-point adplug/cff.cpp:381
[  168s] W: deadbeef sequence-point adplug/dmo.cpp:323, 343, 367
[  168s] W: deadbeef sequence-point lh5dec.c:95
[  168s] W: deadbeef sequence-point ttadec.c:515
[  168s] 
[  168s] I: Program is using uninitialized variables.
[  168s]    Note the difference between "is used" and "may be used"
[  168s] W: deadbeef uninitialized-variable ../../plugins/sid/sidplay-libs/libsidplay/include/sidplay/sidendian.h:91
[  168s] 
[  168s] I: Program returns random data in a function
[  168s] E: deadbeef no-return-in-nonvoid-function artwork.c:229
[  168s] E: deadbeef no-return-in-nonvoid-function streamer.c:810, 818, 826
[  168s] E: deadbeef no-return-in-nonvoid-function vorbis.c:134
[  168s] 
[  168s] I: Program returns random data in a function
[  168s] E: deadbeef no-return-in-nonvoid-function artwork.c:229
[  168s] E: deadbeef no-return-in-nonvoid-function streamer.c:810, 818, 826
[  168s] E: deadbeef no-return-in-nonvoid-function vorbis.c:134
[  168s] 
[  168s] I: Expression compares a char* pointer with a string literal.
[  168s]    Usually a strcmp() was intended by the programmer
[  168s] E: deadbeef stringcompare widgets.c:1179, 1212
---
 plugins/adplug/adplug/cff.cpp |    5 ++++-
 plugins/adplug/adplug/dmo.cpp |   15 ++++++++++++---
 plugins/artwork/artwork.c     |    1 +
 plugins/gtkui/widgets.c       |    4 ++--
 plugins/tta/ttadec.h          |    2 +-
 plugins/vorbis/vorbis.c       |    7 ++-----
 plugins/vtx/lh5dec.c          |    2 +-
 streamer.c                    |    6 +++---
 8 files changed, 26 insertions(+), 16 deletions(-)

Index: deadbeef-0.6.2/plugins/adplug/adplug/cff.cpp
===================================================================
--- deadbeef-0.6.2.orig/plugins/adplug/adplug/cff.cpp
+++ deadbeef-0.6.2/plugins/adplug/adplug/cff.cpp
@@ -378,7 +378,10 @@ long CcffLoader::cff_unpacker::unpack(un
 	  }
 
 	  for (unsigned int i=0;i<repeat_counter*repeat_length;i++)
-	    output[output_length++] = output[output_length - repeat_length];
+	    {
+	      output[output_length] = output[output_length - repeat_length];
+	      output_length++;
+	    }
 
 	  code_length = old_code_length;
 
Index: deadbeef-0.6.2/plugins/adplug/adplug/dmo.cpp
===================================================================
--- deadbeef-0.6.2.orig/plugins/adplug/adplug/dmo.cpp
+++ deadbeef-0.6.2/plugins/adplug/adplug/dmo.cpp
@@ -320,7 +320,10 @@ short CdmoLoader::dmo_unpacker::unpack_b
 	    return -1;
 
 	  for(int i=0;i<cx;i++)
-	    *opos++ = *(opos - ax);
+	    {
+	      *opos = *(opos - ax);
+	      *opos++;
+	    }
 
 	  continue;
 	}
@@ -340,7 +343,10 @@ short CdmoLoader::dmo_unpacker::unpack_b
 	    return -1;
 
 	  for(i=0;i<cx;i++)
-	    *opos++ = *(opos - ax);
+	    {
+	      *opos = *(opos - ax);
+	      *opos++;
+	    }
 
 	  for (i=0;i<bx;i++)
 	    *opos++ = *ipos++;
@@ -364,7 +370,10 @@ short CdmoLoader::dmo_unpacker::unpack_b
 	    return -1;
 
 	  for(i=0;i<cx;i++)
-	    *opos++ = *(opos - bx);
+	    {
+	      *opos = *(opos - bx);
+	      *opos++;
+	    }
 
 	  for (i=0;i<ax;i++)
 	    *opos++ = *ipos++;
Index: deadbeef-0.6.2/plugins/artwork/artwork.c
===================================================================
--- deadbeef-0.6.2.orig/plugins/artwork/artwork.c
+++ deadbeef-0.6.2/plugins/artwork/artwork.c
@@ -226,6 +226,7 @@ make_cache_path2 (char *path, int size,
             *p = '_';
         }
     }
+    return 0;
 }
 
 static void
Index: deadbeef-0.6.2/plugins/gtkui/widgets.c
===================================================================
--- deadbeef-0.6.2.orig/plugins/gtkui/widgets.c
+++ deadbeef-0.6.2/plugins/gtkui/widgets.c
@@ -1176,7 +1176,7 @@ w_splitter_lock (w_splitter_t *w) {
     }
     w->locked = 1;
 
-    int vert = w->base.type == "vsplitter";
+    int vert = strcmp(w->base.type, "vsplitter");
 
     GtkAllocation a;
     gtk_widget_get_allocation (w->base.widget, &a);
@@ -1209,7 +1209,7 @@ w_splitter_unlock (w_splitter_t *w) {
     }
     w->locked = 0;
 
-    int vert = w->base.type == "vsplitter";
+    int vert = strcmp(w->base.type, "vsplitter");
     // convert back to vpaned
     GtkWidget *paned = vert ? gtk_vpaned_new () : gtk_hpaned_new ();
     gtk_widget_set_can_focus (paned, FALSE);
Index: deadbeef-0.6.2/plugins/tta/ttadec.h
===================================================================
--- deadbeef-0.6.2.orig/plugins/tta/ttadec.h
+++ deadbeef-0.6.2/plugins/tta/ttadec.h
@@ -81,7 +81,7 @@ typedef unsigned char byte;
 #endif
 
 #define PREDICTOR1(x, k)	((int)((((uint64)x << k) - x) >> k))
-#define DEC(x)			(((x)&1)?(++(x)>>1):(-(x)>>1))
+#define DEC(x)			(((x)&1)?((++(x))>>1):((-(x))>>1))
 
 typedef struct {
 	unsigned int TTAid;
Index: deadbeef-0.6.2/plugins/vorbis/vorbis.c
===================================================================
--- deadbeef-0.6.2.orig/plugins/vorbis/vorbis.c
+++ deadbeef-0.6.2/plugins/vorbis/vorbis.c
@@ -114,7 +114,7 @@ is_special_tag(const char *tag) {
            !strcasecmp(tag, gain_tag_name(RG_REFERENCE_LOUDNESS));
 }
 
-static bool
+static void
 add_meta(DB_playItem_t *it, const char *key, const char *value)
 {
     const char *old_value = deadbeef->pl_find_meta(it, key);
@@ -124,12 +124,9 @@ add_meta(DB_playItem_t *it, const char *
             sprintf(new_value, "%s"DELIMITER"%s", old_value, value);
             deadbeef->pl_replace_meta(it, key, new_value);
             free(new_value);
-            return true;
         }
-    }
-    else {
+    } else {
         deadbeef->pl_add_meta(it, key, value);
-        return true;
     }
 }
 
Index: deadbeef-0.6.2/plugins/vtx/lh5dec.c
===================================================================
--- deadbeef-0.6.2.orig/plugins/vtx/lh5dec.c
+++ deadbeef-0.6.2/plugins/vtx/lh5dec.c
@@ -92,7 +92,7 @@ static void make_table(int nchar, unsign
     start[i] >>= jutbits;
     weight[i] = 1U << (tablebits - i);
   }
-  while (i <= 16) weight[i++] = 1U << (16 - i);
+  while (i <= 16) { weight[i] = 1U << (16 - i); i++; }
 
   i = start[tablebits + 1] >> jutbits;
   if (i != (unsigned short)(1U << 16)) {
Index: deadbeef-0.6.2/streamer.c
===================================================================
--- deadbeef-0.6.2.orig/streamer.c
+++ deadbeef-0.6.2/streamer.c
@@ -806,7 +806,7 @@ streamer_move_to_nextsong (int r) {
     if (r) {
         streamer_abort_files ();
     }
-    handler_push (handler, STR_EV_NEXT, 0, r, 0);
+    return handler_push (handler, STR_EV_NEXT, 0, r, 0);
 }
 
 int
@@ -814,7 +814,7 @@ streamer_move_to_prevsong (int r) {
     if (r) {
         streamer_abort_files ();
     }
-    handler_push (handler, STR_EV_PREV, 0, r, 0);
+   return  handler_push (handler, STR_EV_PREV, 0, r, 0);
 }
 
 int
@@ -822,7 +822,7 @@ streamer_move_to_randomsong (int r) {
     if (r) {
         streamer_abort_files ();
     }
-    handler_push (handler, STR_EV_RAND, 0, r, 0);
+    return handler_push (handler, STR_EV_RAND, 0, r, 0);
 }
 
 // playlist must call that whenever item was removed