Request 4503 (accepted)

Overview

Request 4503 (accepted)

- Spec cleanup

Created by bitstreamout over 5 years ago
In state accepted

Submit r8168

Submit package Essentials / r8168 to package home:bitstreamout:Essentials / r8168

r8168.changes Changed

r8168.spec Changed

@@ -1,6 +1,7 @@
 #
 # spec file for package r8168
 #
+# Copyright (c) 2019 Packman Team <packman@links2linux.de>
 # Copyright (c) 2017 SUSE LINUX Products GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
@@ -12,18 +13,20 @@
 # license that conforms to the Open Source Definition (Version 1.9)
 # published by the Open Source Initiative.
 
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.links2linux.org/
 #
 
+
 Name:           r8168
 Version:        8.047.01
 Release:        0
-License:        GPL-2.0+
 Summary:        Device driver for RealTek Gigabit Ethernet controllers
-# Compare with https://github.com/mtorromeo/r8168 and
-Url:            https://www.realtek.com/en/component/zoo/category/network-interface-controllers-10-100-1000m-gigabit-ethernet-pci-express-software
+License:        GPL-2.0-or-later
 Group:          System/Kernel
-Source0:        r8168-8.047.01.tar.bz2
+# Compare with https://github.com/mtorromeo/r8168 and
+# http://www.realtek.com.tw/Downloads/downloadsView.aspx?Langid=1&PNid=13&PFid=5&Level=5&Conn=4&DownTypeID=3&GetDown=false#2
+URL:            https://www.realtek.com/en/component/zoo/category/network-interface-controllers-10-100-1000m-gigabit-ethernet-pci-express-software
+Source0:        %{name}-%{version}.tar.bz2
 Source1:        preamble
 Source2:        Module.supported
 Patch0:         r8168-kernel_version.patch
@@ -33,8 +36,7 @@
 BuildRequires:  libelf-devel
 BuildRequires:  module-init-tools
 Requires:       r8168-kmp
-BuildRoot:      %{_tmppath}/%{name}-%{version}-build
-ExcludeArch:    s390 s390x
+ExclusiveArch:  %{ix86} x86_64
 %kernel_module_package -p preamble
 
 %description
@@ -57,17 +59,17 @@
 %setup -q
 %patch0 -b .p0
 %patch1 -b .p1
-cp %{S:1} .
-cp %{S:2} .
+cp %{SOURCE1} .
+cp %{SOURCE2} .
 
 %build
 ln -sf $(type -p kmod) modinfo
-%{__mkdir} obj
+mkdir obj
 for flavor in %{flavors_to_build}
 do
-    %{__rm}   -rf obj/$flavor
-    %{__cp}   -rp src obj/$flavor
-    %{__make} -C %{kernel_source $flavor} M=$PWD/obj/$flavor modules
+    rm   -rf obj/$flavor
+    cp   -rp src obj/$flavor
+    make -C %{kernel_source $flavor} M=$PWD/obj/$flavor modules
     ./modinfo -F alias $(find $PWD/obj/$flavor/ -name '%{name}.ko')
 done
 
@@ -76,21 +78,17 @@
 export INSTALL_MOD_DIR=updates
 for flavor in %{flavors_to_build}
 do
-    %{__make} -C %{kernel_source $flavor} M=$PWD/obj/$flavor modules_install
+    make -C %{kernel_source $flavor} M=$PWD/obj/$flavor modules_install
 done
-%{__mkdir_p} %{buildroot}%{_sysconfdir}/modprobe.d/
+mkdir -p %{buildroot}%{_sysconfdir}/modprobe.d/
 cat > %{buildroot}%{_sysconfdir}/modprobe.d/50-blacklist-r8169.conf<<-'EOF'
 	# On many Realtek Ethernet controllers the old device driver r8169 does
-	# not work reliably.  To solve this the r8169 kernel module has to be 
+	# not work reliably.  To solve this the r8169 kernel module has to be
 	# blacklisted to enable the system to load the new device driver r8168.
 	blacklist r8169
 	EOF
 
-%clean
-%{__rm} -rf %{buildroot}
-
 %files blacklist-r8169
-%defattr(-, root, root)
 %config %{_sysconfdir}/modprobe.d/50-blacklist-r8169.conf
 
 %changelog

Build Results
RPM Lint

Refresh

Comments for request 4503 0

Request History

bitstreamout created request over 5 years ago

- Spec cleanup

bitstreamout accepted request over 5 years ago

Got it