Request 5002 (accepted)

We truncated the diff of some files because they were too big. If you want to see the full diff for every file, click here.

Overview

Request 5002 (accepted)

- Update version to 1.30
* Fix Joint Stereo coding, drop faac-fix-broken-joint-stereo.patch
* Code cleanup and compilation fixes
* Fix endianness conversion functions
* Fix compilation with GCC < 4.6
* Fix compilation on big endian systems
* Fix division by zero errors
* Fix compilation with GCC <= 4.7.3
* Change pointer type for proper arithmetics
* Fix logic error in compiler detection
* Revert back to some more generic SSE2 code
* Fix a memory leak
* Fix some cppcheck warnings in the Cfaac code
* Check index ranges before dereferencing book arrays (CVE-2018-19886)
* Clean up stdint.h header inclusions
* Consistently use stdint.h types
* Update Visual Studio 2017 projects
* Add stdint.h header inclusions
* Port over ac2ver tool from faad2 to generate PACKAGE_VERSION
* when compiling with Visual Studio
* Memory allocations redefined (forwarded request 5001 from hillwood)

Created by hillwood about 4 years ago
In state accepted
Package maintainers: detrei and mantre

Submit faac

Submit package Staging / faac to package Essentials / faac

faac.changes Changed

@@ -1,4 +1,29 @@
 -------------------------------------------------------------------
+Thu Feb 13 07:20:21 UTC 2020 - Hillwood Yang <hillwood@opensuse.org>
+
+- Update version to 1.30
+  * Fix Joint Stereo coding, drop faac-fix-broken-joint-stereo.patch
+  * Code cleanup and compilation fixes
+  * Fix endianness conversion functions
+  * Fix compilation with GCC < 4.6
+  * Fix compilation on big endian systems
+  * Fix division by zero errors
+  * Fix compilation with GCC <= 4.7.3
+  * Change pointer type for proper arithmetics
+  * Fix logic error in compiler detection
+  * Revert back to some more generic SSE2 code
+  * Fix a memory leak
+  * Fix some cppcheck warnings in the Cfaac code
+  * Check index ranges before dereferencing book arrays (CVE-2018-19886)
+  * Clean up stdint.h header inclusions
+  * Consistently use stdint.h types
+  * Update Visual Studio 2017 projects
+  * Add stdint.h header inclusions
+  * Port over ac2ver tool from faad2 to generate PACKAGE_VERSION
+  * when compiling with Visual Studio
+  * Memory allocations redefined
+
+-------------------------------------------------------------------
 Sat Dec 30 20:58:00 UTC 2017 - zaitor@opensuse.org
 
 - Add faac-fix-broken-joint-stereo.patch: The recent introduction

faac.spec Changed

@@ -19,19 +19,20 @@
 %define major     0
 %define lib       libfaac
 %define libname   %{lib}%{major}
+%define _version  1_30
 
 Name:           faac
-Version:        1.29.9.2
+Version:        1.30
 Release:        0
 Summary:        Frontend for encoding MPEG2/4 AAC
 # Original Code was free to use but restricted. Modifications are LGPL-2.1+
 License:        SUSE-Freeware and LGPL-2.1+
 Group:          Productivity/Multimedia/Video/Editors and Convertors
-Url:            http://www.audiocoding.com/
-Source0:        https://sourceforge.net/projects/faac/files/faac-src/faac-1.29/%{name}-%{version}.tar.gz
+Url:            https://github.com/knik0/faac
+Source0:        https://github.com/knik0/faac/archive/%{_version}/%{name}-%{version}.tar.gz
 Source99:       baselibs.conf
-Patch0:         faac-fix-broken-joint-stereo.patch
 BuildRequires:  gcc-c++
+BuildRequires:  gnome-common
 Requires:       %{libname} = %{version}
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 
@@ -65,13 +66,13 @@
 Header files and static library for the faac library
 
 %prep
-%autosetup -p1
+%setup -q -n %{name}-%{_version}
 
 %build
-%configure \
-           --enable-shared \
+autoreconf -fi
+%configure --enable-shared \
            --disable-static
-make %{?_smp_mflags}
+%make_build
 
 %install
 %make_install
@@ -82,7 +83,8 @@
 
 %files
 %defattr(-, root, root)
-%doc AUTHORS COPYING ChangeLog NEWS README TODO
+%doc AUTHORS ChangeLog NEWS README TODO
+%license COPYING
 %{_bindir}/*
 %{_mandir}/man1/faac.1%{ext_man}

faac-fix-broken-joint-stereo.patch Deleted

faac-1.29.9.2.tar.gz -> faac-1.30.tar.gz Changed

Build Results
RPM Lint

Refresh

Mentioned Issues (1)

CVE-2018-19886

Comments for request 5002 0

Request History

hillwood created request about 4 years ago

hillwood accepted request about 4 years ago