Request 6389 (accepted)

We truncated the diff of some files because they were too big. If you want to see the full diff for every file, click here.

Overview

Request 6389 (accepted)

New upstream release (with CVE fixes).
Note the aarch64 builds seems a bit flaky, kicking off a new rebuild let the builds compile without errors, so not sure whats going on there.

Created by zaitor 3 months ago
In state accepted
Open review for Staging / libde265

Submit libde265

Submit package Staging / libde265 to package Essentials / libde265

libde265.changes Changed

libde265.spec Changed

@@ -18,7 +18,7 @@
 
 %define so_ver  0
 Name:           libde265
-Version:        1.0.16
+Version:        1.0.17
 Release:        0
 Summary:        Open H.265 video codec implementation
 License:        LGPL-3.0-only
@@ -26,12 +26,9 @@
 URL:            https://www.libde265.org/
 Source0:        https://github.com/strukturag/libde265/releases/download/v%{version}/%{name}-%{version}.tar.gz
 Source99:       baselibs.conf
-Patch0:         libde265-disable_tools.patch
-Patch1:         https://github.com/strukturag/libde265/commit/03219835991f44c7ecf4dcc6fa8066967561be7e.patch
-Patch2:         https://github.com/strukturag/libde265/commit/67831118e3d6961fab4c29fc4364fa0eccfb8473.patch
-BuildRequires:  automake
+
 BuildRequires:  c++_compiler
-BuildRequires:  libtool
+BuildRequires:  cmake
 BuildRequires:  pkgconfig
 
 %description
@@ -67,19 +64,14 @@
 %autosetup -p1
 
 %build
-NOCONFIGURE=1 ./autogen.sh
-%configure \
-	--disable-static \
-	--enable-shared \
-	--disable-encoder \
-	--disable-dec265 \
-	--disable-sherlock265 \
+%cmake \
+	-D ENABLE_SDL=OFF \
+	-D ENABLE_DECODER=OFF \
 	%{nil}
-%make_build
+%cmake_build
 
 %install
-%make_install
-find %{buildroot} -type f -name "*.la" -delete -print
+%cmake_install
 
 %ldconfig_scriptlets -n %{name}-%{so_ver}
 
@@ -90,6 +82,8 @@
 %files devel
 %doc AUTHORS README.md
 %{_includedir}/%{name}/
+%dir %{_libdir}/cmake/%{name}
+%{_libdir}/cmake/%{name}/%{name}*.cmake
 %{_libdir}/%{name}.so
 %{_libdir}/pkgconfig/%{name}.pc

03219835991f44c7ecf4dcc6fa8066967561be7e.patch Deleted

@@ -1,55 +0,0 @@
-From 03219835991f44c7ecf4dcc6fa8066967561be7e Mon Sep 17 00:00:00 2001
-From: Victor Loh <vloh@fb.com>
-Date: Mon, 5 May 2025 13:05:53 -0700
-Subject: PATCH libde265 Fix potential data race in image.cc
-
-There could be potential data race causing s_next_image_ID to not be minting out
-ID in monotonically increasing order. Before this fix, there was an TSAN failure
-and with this fix, the TSAN failure is resolved.
----
- libde265/image.cc | 5 +++--
- libde265/image.h  | 1 -
- 2 files changed, 3 insertions(+), 3 deletions(-)
-
-diff --git a/libde265/image.cc b/libde265/image.cc
-index fdc80fc2..6acd8c15 100644
---- a/libde265/image.cc
-+++ b/libde265/image.cc
-@@ -22,6 +22,8 @@
- #include "decctx.h"
- #include "en265.h"
- 
-+#inclue <atomic>
-+
- #include <stdlib.h>
- #include <string.h>
- #include <assert.h>
-@@ -187,8 +189,6 @@ void de265_image::set_image_plane(int cIdx, uint8_t* mem, int stride, void *user
- }
- 
- 
--uint32_t de265_image::s_next_image_ID = 0;
--
- de265_image::de265_image()
- {
-   ID = -1;
-@@ -249,6 +249,7 @@ de265_error de265_image::alloc_image(int w,int h, enum de265_chroma c,
-                 allocated to the requested size. Without the release, the old image-data
-                 will not be freed. */
- 
-+  static std::atomic<uint32_t> s_next_image_ID(0);
-   ID = s_next_image_ID++;
-   removed_at_picture_id = std::numeric_limits<int32_t>::max();
- 
-diff --git a/libde265/image.h b/libde265/image.h
-index 3779580c..78a79de2 100644
---- a/libde265/image.h
-+++ b/libde265/image.h
-@@ -344,7 +344,6 @@ struct de265_image {
- 
- private:
-   uint32_t ID;
--  static uint32_t s_next_image_ID;
- 
-   uint8_t* pixels3;
-   uint8_t  bpp_shift3;  // 0 for 8 bit, 1 for 16 bit

67831118e3d6961fab4c29fc4364fa0eccfb8473.patch Deleted

libde265-disable_tools.patch Deleted

libde265-1.0.16.tar.gz -> libde265-1.0.17.tar.gz Changed

Build Results
RPM Lint

Refresh

Mentioned Issues (2)

CVE-2026-33164
CVE-2026-33165

Comments for request 6389 0

Request History

zaitor created request 3 months ago

New upstream release (with CVE fixes).
Note the aarch64 builds seems a bit flaky, kicking off a new rebuild let the builds compile without errors, so not sure whats going on there.

manfred-h accepted request 3 months ago

lgtm, thanks! Don't know about what the issues with the aarch64 builds are, though.